test: add tests for miscellaneous ioctl functions#1034
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Jul 8, 2025
Merged
test: add tests for miscellaneous ioctl functions#1034igaw merged 1 commit intolinux-nvme:masterfrom
igaw merged 1 commit intolinux-nvme:masterfrom
Conversation
Contributor
Author
|
Going to fix the failing test case soon :) |
MaisenbacherD
force-pushed
the
test-misc
branch
2 times, most recently
from
b84cacf to
860893a
Compare
Use the mock ioctl infrastructure to test the functions in ioctl.h that issue miscellaneous ioctl commands. Signed-off-by: Dennis Maisenbacher <[email protected]>
MaisenbacherD
commented
Jul 8, 2025
Contributor
Author
MaisenbacherD
left a comment
MaisenbacherD
left a comment
There was a problem hiding this comment.
I am happy to get some feedback, specifically on the highlighted section :)
Comment on lines
+418
to
+419
| _cleanup_free_ struct nvme_lba_status *lbas = NULL; | ||
| _cleanup_free_ struct nvme_lba_status *expected_lbas = NULL; |
Contributor
Author
There was a problem hiding this comment.
@igaw Is this use of _cleanup_free_ idiomatic? I am happy to hear your thoughts on this. :)
Collaborator
There was a problem hiding this comment.
It avoids the common pitfall that the error path is never really tested and usually something gets leaked. So yes, if the scope of the allocation is within a block, it makes sense to use these cleanup function. FWIW, even the kernel started to use these :)
Collaborator
There was a problem hiding this comment.
Maybe we should add something like a util.h for the tests later.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the mock ioctl infrastructure to test the functions in ioctl.h that issue miscellaneous ioctl commands.